tests: Allow test suite to run on mac #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
tests_use_dial_stdio
branch
2 times, most recently
from
7310e1e
to
8d4a319
Compare
This makes it so the test suite can connect to any buildx instance using `docker buildx dial-stdio`. In this case the client connection is proxied over the stdin/stdout of the buildx command. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
Remove the code that falls back to the old behavior of trying to parse the buildx directory. This makes tests require buildx >= 0.13. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
tests_use_dial_stdio
branch
from
8d4a319
to
ac1aea0
Compare
1. In the test fixtures we are generating LLB from the client. This LLB was assuming the clients platform, however this should use the worker's platform. This allows the fixtures to be built from a Mac client (e.g. Docker for Mac). 2. There is currently no Windows arm64 image as such just set the tests to use amd64 as an explicit platform. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
changed the title
|
@jeremyrickard LGTY? |
|
@cpuguy83 I was able to run the tests locally on my Mac with your branch, so I think this is good to go. |
jeremyrickard
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildx dial-stdiosubcommand for creating a buildkit client. This not only allows any buildx instance to be used, in particular it unblocks docker desktop.